Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Totality validation for merge operation #58600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

z3rone
Copy link

@z3rone z3rone commented May 6, 2024

@WillAyd
Copy link
Member

WillAyd commented May 16, 2024

Hmm I'm not too sure about adding this - the validation keyword strictly deals with cardinality today. This seems to blur that scope a little.

Does a library like great expectations not already have something to solve your need?

@z3rone
Copy link
Author

z3rone commented May 17, 2024

@WillAyd I would argue that adding totality has a special significance. It would enable the validation of the cardinalities defined by the entity relationship model.

This defines a clear scope for what the validate option's itention is and also adds compatability with the most common modeling language for merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add totality validation to merge method
2 participants