Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more thorough examples for predicates #2345

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

maschad
Copy link
Member

@maschad maschad commented May 20, 2024

This PR seeks to improve the documentation surrounding predicates in the SDK, this includes

Closes #2311

@Torres-ssf Torres-ssf added the docs Requests pertinent to documentation label May 20, 2024
@maschad maschad requested a review from danielbate May 21, 2024 20:31
@maschad maschad force-pushed the mc/docs/improve-predicate-docs branch from 203b3fe to c665dfe Compare May 21, 2024 20:48
arboleya

This comment was marked as resolved.

Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

apps/docs/src/guide/predicates/methods.md Outdated Show resolved Hide resolved
apps/docs/src/guide/predicates/methods.md Outdated Show resolved Hide resolved
apps/docs/src/guide/predicates/methods.md Outdated Show resolved Hide resolved
maschad and others added 2 commits May 22, 2024 19:06
maschad and others added 2 commits May 23, 2024 10:25
Co-authored-by: Daniel Bate <djbate23@gmail.com>
Co-authored-by: Daniel Bate <djbate23@gmail.com>
@maschad maschad marked this pull request as draft May 24, 2024 20:13
return toast.error("Please enter a pin");
}

const configurable = { PIN: bn(pin) };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhaiwat10 I'm uncertain as to whether this is idiomatic React, I primarily did things this way as it seemed to be more favourable to the nuances of how React manages state. I'd be keen to hear your insights.

@maschad maschad marked this pull request as ready for review June 10, 2024 15:09
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
45.09%(-0.38%) 38.14%(-0.43%) 42.05%(-0.23%) 44.88%(-0.36%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/create-fuels-counter-guide/src/pages/predicate.tsx 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thorough example for Predicates
6 participants