-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestFailure: TestMergePositionsMultipleGeometries - Index was outside the bounds of the array. #8140
Comments
You can test further by updating the MathHelper.CalculateTangentFrames and changing the Normals check from a Return (skip processing missing normals) to the commented-out line MeshHelper.CalculateNormals(geom, true); (Generate missing normals)
This is then tested by the newer MissingNormalsTestCustom test, which has a model that includes Normals and is missing normals on some geometry.
The test fails if you attempt to use the CalculateNormals method to regenerate the missing ones. |
…TestMergePositionsMultipleGeometries
…ilure-TestMergePositionsMultipleGeometries Update MeshHelper to fix #8140
Prerequisites
develop
branchMonoGame Version
Develop
Which MonoGame platform are you using?
N/A
Operating System
ALl
Description
The function
MeshHelper.CalculateNormals
has an issue in generating the Normals for models, resulting in a failed Unit Test in the MonoGame.Tools solution.The issue relates in to the creation of a VertextChannel array for the Geometry normals (Line 130 -
MeshHelper
)Steps to Reproduce
TestMergePositionsMultipleGeometries
test(Run in Bebug to see the specific failure)
Minimal Example Repo
No response
Expected Behavior
MeshHelper.CalculateNormals should complete successfully
Resulting Behavior
TestMergePositionsMultipleGeometries
test failureFiles
No response
The text was updated successfully, but these errors were encountered: