Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Sentry logging #53

Open
joris-burgers opened this issue Sep 12, 2019 · 2 comments
Open

Add tests for Sentry logging #53

joris-burgers opened this issue Sep 12, 2019 · 2 comments

Comments

@joris-burgers
Copy link
Contributor

Icepeak logs errors to Sentry in case an exception occurs (see #52). It would be nice to see a number of tests that verify this functionality. These tests would somehow cause Icepeak to crash deliberately and verify that the correct errors are send to the Sentry DSN that is specified, for example by inspecting the records that are send from Icepeak. It should not be possible to let Icepeak crash when in production.

@NunoAlexandre
Copy link
Contributor

for example by inspecting the records that are send from Icepeak

Hi @joris-burgers! Do you know or have in mind a way of doing so?

@joris-burgers
Copy link
Contributor Author

Hi @NunoAlexandre, I was personally thinking about the module System.Log.Raven.Transport.Debug of the raven-haskell package we use for Icepeak. This would allow us to swap out the destination where Sentry would sent error messages, which we could then inspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants