-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel build on windows fails with error from swift #8301
Comments
Hej, thanks for opening the issue. No, Swift isn't a prerequisite to building with Bazel. I would say it's mainly for macOS and Linux. Unfortunately, my knowledge with Bazel is none-existing to solve this actually. |
This can be fixed with these two changes: build_grpc_with_cxx14.patch:
.bazelrc:
The windows build command is then: |
Would you be able to upstream this? |
Well, not anytime this week, but I can look at it on Monday. Would that be fine? cc: @dbaileychess |
Amazing! Thanks :-) I'm also looking at whether we can add the bazel extensions to the conan package, so people using bazel can consume flatbuffers from conan. I'll followup on that one separately if successful. |
@peakschris I wonder what would this code below fix:
Since I know we are having an issue building with Xcode 15.0 as well with gRPC that was fixed by limiting Xcode to 14.2 which isn't optimal commit. CI issue https://buildkite.com/bazel/flatbuffers/builds/9316#018e2ff5-e5ca-46e5-afc1-74d96b161517 |
All I've changed in that patch file is to use Original patch file:
Modified patch file:
It looks like a different issue to the Xcode one. |
I'm not sure if it's supposed to work, but the bazel build of latest on windows is broken:
We have a requirement to compile the flatbuffers library with msvc, so switching to clang is a non-starter for us. Is swift a real prerequisite for C++?
The text was updated successfully, but these errors were encountered: