-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terminal profiles broken again #3275
Comments
Can't reproduce |
I can reproduce this - on latest stable even. Though slightly different from the original issue because it's only the first tab. If I hit the term config: [terminal]
font-family = "'Hasklug NF', 'Hasklug Nerd Font'"
font-size = 14
[terminal.default-profile]
windows = "msys"
[terminal.profiles.msys]
args = ["--login", "-i"]
command = "C:/msys64/usr/bin/bash.exe"
env = {MSYSTEM = "MINGW64", CHERE_INVOKING = "1", MSYS2_PATH_TYPE = "inherit", MSYS2_NOSTART = "yes", MSYSCON = "defterm"} @maddes8cht you might wanna test for this as well. Though granted, it kinda sucks to have to open two shells to get the one you want. |
An issue that wasn't fixed in stable.. |
I was merely surprised a commit causing an issue in nightly that wasn't noted until a few days before the stable release got through; I figured the time frame would be larger than the few days between this issue and the 0.4.0 release. If I were to be mad about issues in stable, there's be lower hanging fruit. Small update on the issue at hand: |
this config is invalid btw. |
I can't exactly tell what's invalid about that config tbh; what would be breaking about it? |
Changing those to match the keys as used in the example does indeed impact the opened env, and removing |
Okay so I did manage to find the code path triggering the wrong profile being loaded on clean terminal pane tabs. After that I'm hitting a dead end, as the defaults should result in an eventual situation of creating a console host with no target program, which I think should crash or spin up cmd.exe on w10? Save for Windows Terminal I don't know if anything explicitly defaults to or falls back on powershell or if that was changed recently. And searching the code doesn't help as Lapce makes very few mentions of any default shells. |
Fixed via af72732 |
Lapce Version
nightly -11f36a7
System information
Windows 10
Describe the bug
With the current nightly, the formerly closed issue #3244 is back again and worse than before:
settings.toml
i posted in Terminal Settings Behaviour Not as Expected - TOML Parser Issue and Start Behaviour #3244 stop working again (again it always opens powershell)Terminal: default profile
there is onlydefault
available, the otherconfigured terminals have disappeared.
Additional information
The last item in my list is very inconsistent and not very reproducible, thus i don't have screenshots or .toml file content for this.
I experienced once that the automatically written settings.toml was garbaged in the way that almost all closing bracket like
]
,}
and even closing"
had vanished, causing lapce to be stalled when loading.I also experienced when changing the
core: Color Theme
setting that i got asettings.toml
with only the setting for thecore: Color Theme
, all other settings had been deleted. This seems more reproducible.The text was updated successfully, but these errors were encountered: