Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultLinesDiffComputer did not pass timeout as an option #213034

Closed
CharlesHGong opened this issue May 19, 2024 · 0 comments · Fixed by #213035
Closed

DefaultLinesDiffComputer did not pass timeout as an option #213034

CharlesHGong opened this issue May 19, 2024 · 0 comments · Fixed by #213035
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@CharlesHGong
Copy link
Contributor

CharlesHGong commented May 19, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: Latest Master

In src/vs/editor/common/diff/defaultLinesDiffComputer/defaultLinesDiffComputer.ts

return this.myersDiffingAlgorithm.compute(
  sequence1,
  sequence2
);

This caller is missing to pass in the timeout variable.

The definition of the myersDiffingAlgorithm.compute looks like this

compute(seq1: ISequence, seq2: ISequence, timeout: ITimeout = InfiniteTimeout.instance)
@Yoyokrazy Yoyokrazy assigned hediet and unassigned alexdima May 20, 2024
@hediet hediet added this to the May 2024 milestone May 27, 2024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
4 participants