-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Error Feedback in colab/demo.ipynb Data Processing Steps #3123
Comments
It currently fail for me with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Yes, when running the "Downloading and Processing Data" step in
colab/demo.ipynb
, the message "Data Processing Succeeded!" is displayed regardless of whether the actual processing was successful.This is because the script checks for the existence of
transforms.json
during the training step. If the file is missing, the system advises, "Please re-run 'Downloading and Processing Data', or view the FAQ for more info." This may cause confusion, especially for beginners, as the message suggest successful processing when there may be underlying errors, such as those related to COLMAP and its dependencies. Simply re-running the block does not necessarily resolve these failures.Describe the solution you'd like
A straightforward solution is to move the verification step earlier. The message "Data Processing Succeeded!" should only be displayed if the required output file is present. If not, a more informative error message should guide the user. For example:
The text was updated successfully, but these errors were encountered: