fix: handle differing source and result sizes in updateCanvas #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle differing source and results sizes in updateCanvas when the coordinates left and top are less than 0
|
This has been open for over a month now. @Norserium anything I can do to get this merged? |
|
This has been open for over two months now. @Norserium anything I can do to get this merged? |
|
@DerZade, I will look this pull request on this weekend. |
|
@DerZade, your pull request is great, thank your for the important fix! There is only one nuance. The changes that common to both versions are pushed to Don't you mind if I commit this change by myself? If you do mind, please create the pull request from |
|
Closed in favor of #276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateCanvashas a bug which only really comes to light if the size of the canvas and the size of the original image differ drastically and the image offset is positive. Thedxanddyare not adjusted for the size difference.Here is a visual representation:
Since the output (100px) is half the size of the input (200px) the
dxanddyhave to be halfed.The same issue seems to exist in the master branch. I'll gladly also create a PR for the master branch, once this is merged :)