-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dask.array.fft
mismatch with Numpy's interface (add support for norm
argument)
#10665
base: main
Are you sure you want to change the base?
Conversation
scipy.fftpack is now legacy as it doesn't follow numpy.fft API and they suggest using scipy.fft scipy/scipy#19005
Not dask.array.fft follows same API as numpy.fft
Can one of the admins verify this patch? Admins can comment |
norm
argument)dask.array.fft
mismatch with Numpy's interface (add support for norm
argument)
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 23m 3s ⏱️ +22s For more details on these failures, see this check. Results for commit c062618. ± Comparison against base commit a291fd2. This pull request removes 28 and adds 28 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Hi! I'm reaching out to see if there's anything more I can do to facilitate the review process. |
norm
argument was needed to match numpy.fft API.norm
match NumPy's.pre-commit run --all-files