dask.array.tensordot bugfix: ensure axes are positive / add tests for negative axes
#10812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensordot in numpy accepts negative axes, however negative axes in dask.array.tensordot these give wrong results.
|
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 22m 59s ⏱️ +18s For more details on these failures, see this check. Results for commit 83e636f. ± Comparison against base commit a291fd2. ♻️ This comment has been updated with latest results. |
joanrue
changed the title
dask.array.tensordot bugfix: ensure axes are positive / add tests for negative axes
|
Hi! I'm reaching out to see if there's anything more I can do to facilitate the review process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
numpy.tensordotaccepts negative axes, negative axes indask.array.tensordotwere giving wrong results. This bug is easily fixed by ensuring that the left axes are positive before the sum-reduction step.dask.array.tensordotbug: negative values in argumentaxesgive wrong results. #10811pre-commit run --all-filesCo-authored-by: Sepand Kashani sepand@kashani.ch