Added 2 new operations 'NTPTimestampToUNIXTimestamp' and 'UNIXTimesta… #1814
+652
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpToNTPTimestamp' allowing to convert NTP timestamp to UNIX timestamp and the other way round
…and 'UNIXTimestampToNTPTimestamp'
|
Failed on UI tests. Can you fix it or do i need to made modifications to the operations code ? |
|
Hello, Any news on this ? |
|
Hey @KossiJunior, this is a really good PR and a nice addition to CyberChef! Could you add the tests you've created to the test runner in this file: https://github.com/gchq/CyberChef/blob/master/tests/operations/index.mjs Other than that, your PR looks ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm adding 2 new operations to convert NTP timestamp to UNIX timestamp and the other way round.
The NTP timestamp is detailed in the following links :
https://www.ntp.org/reflib/y2k/
https://datatracker.ietf.org/doc/html/rfc5905
https://tickelton.gitlab.io/articles/ntp-timestamps/