-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thirtydaysinger] Add Extractor #9894
Open
kieraneglin
wants to merge
4
commits into
yt-dlp:master
Choose a base branch
from
kieraneglin:ke/30-day-singer
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieraneglin
commented
May 9, 2024
bashonly
added
site-request
Request to support a new website
pending-fixes
PR has had changes requested
labels
May 9, 2024
bashonly
reviewed
May 9, 2024
bashonly
requested changes
May 9, 2024
kieraneglin
commented
May 9, 2024
|
||
|
||
class ThirtyDaySingerIE(ThirtyDaySingerBase): | ||
_VALID_URL = r'https?://www\.30daysinger\.com/tutorial/[\w-]+/[\w-]+' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For viz: I'm not creating a match group for the video index here since that's handled in ThirtyDaySingerBase
. Doing it this way allows me to share the logic between the video and playlist extractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Adds extractor for https://www.30daysinger.com.
This site uses Wistia so the the extractor inherits from the existing
WistiaIE
, but it doesn't share the URL structure expected byWistiaIE
orTeachableIE
. Even if I modify these extractors to parse 30daysinger URLs, they don't extract the title or description metadata properly.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?