Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel/preset-env): fix type for core-js version #69642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rtm-ctrlz
Copy link

This change adds an option to specify version of core-js package with a string, what is required to use correct polyfills and transformations.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 19, 2024

@rtm-ctrlz Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 23 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69642,
  "author": "rtm-ctrlz",
  "headCommitOid": "a57e72e70c79894978fc2e15c4a087c4e545e7a2",
  "mergeBaseOid": "98b1a3c7014f74c4c198f318f7acdd988f277658",
  "lastPushDate": "2024-05-19T16:39:32.000Z",
  "lastActivityDate": "2024-05-19T16:39:32.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "babel__preset-env",
      "kind": "edit",
      "files": [
        {
          "path": "types/babel__preset-env/babel__preset-env-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/babel__preset-env/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "slavafomin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2119295735,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels May 19, 2024
@typescript-bot
Copy link
Contributor

🔔 @slavafomin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 19, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 19, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 21, 2024
This change adds an option to specify version of core-js package with a string, what is required to use correct polyfills and transformations.
@typescript-bot typescript-bot removed the Untested Change This PR does not touch tests label May 21, 2024
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 30, 2024
@typescript-bot
Copy link
Contributor

Re-ping @slavafomin:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @rtm-ctrlz.

(Ping @slavafomin.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
New Pull Request Status Board
Needs Maintainer Action
Development

Successfully merging this pull request may close these issues.

None yet

2 participants