JVM Codegen: Step into a function from default arguments #5274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix KT-64731
The main idea is we step into a function, from default arguments assigning(except for default lambda arguments), instead of from header(annotation/modifier/name) of the function. More specifically,for below sample code, the stepping would be:
This PR done this by below code changes:
Creates
IrSetValue
with proper offsets indefaultArgumentStubGeneratorPhase
phase.For
BytecodeInliner
IrSetValue
.For sample code below, it means linenumber 2 is marked for
simpleArg: String = ""
and lineumber 3 is marked forstringMaker: () -> String = { "OK" }
when we call functionfoo$default
with default arguments.astore
instruction for the lambda instance any more, we slightly change the logic ofextractDefaultLambdasInfo
to adapt current design. But what need to be noticed is that we don't mark linenumber forstringMaker: () -> String = { "OK" }
in caller, not before or after this pull request, not inBytecodeInliner
orIrInliner
.For
IrInliner
2.1
described.visitInlinedFunctionBlock