-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display status of sending request steps - INS-3635 #7382
base: develop
Are you sure you want to change the base?
Conversation
0d25008
to
8753e7b
Compare
c05f080
to
3afb742
Compare
}; | ||
|
||
watchRequestTiming(executionId, cb); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dose this useEffect needs a second dependency param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, 2 deps are added.
f0c4f59
to
135544e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feedback
- language is a bit unclear, visually we are looking at a single execution with many steps/phases
- timingrecord is unclear name, rename record to step/phase
- avoid try catch finally for control flow, replace with a clear begin and end process events
- post request script takes double the time taken that it should when i add a setTimeout
- endedAt is not a safe type to be setting to the number 0 because it is used as a date, better would be to make null or a duration rather than a timestamp
- isDone is duplicate data, since we can infer that if endedAt exists then it must be true.
- total time taken breakdown in hover?
50e495a
to
0bab121
Compare
Still todo fix bug where navigating away from a running request loses the loading state. below steps related:
|
29c46fe
to
8a51595
Compare
Changes
Ref: INS-3821, INS-3635