-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Soundboard and VC effects #9349
base: master
Are you sure you want to change the base?
Conversation
Finished: VC effect + VC sound effect Started: Soundboard support
When can we expect this to be undrafted and merged? @Puncher1 |
@SvenLie The GET method is still not supported which, at least for me, doesn't make sense to merge it yet. |
Update
|
3.x is failing due to aiohttp not building on 3.12 and 3.x is latest Python, so CI is blocked on dependencies and not much I can do there. |
This has been tested and is ready for review now. |
I believe the issues with 3.x have been resolved now. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only done a cursory pass at this. It has merge conflicts currently as well, though this feature is pretty complicated and definitely needs documentation on Discord's end for me to merge it.
There are a few things I'm kind of iffy about, some more important than others:
- The name
SoundboardSound
is pretty silly, I'm unsure if goingSoudboard
is any better but it doesn't read as oddly. - The machinery to handle opcode 31 in the gateway seems very complicated for what it is. The chunking mechanism is the way it is because it's expected that multiple events flow in and it needs to be synced and waited. I have no reason to believe soundboard sounds operate the same way but I also have no idea if they do. I tried asking to get clarification on this though I haven't gotten a response yet. I'll update you when I do.
Co-Authored-By: Danny <1695103+Rapptz@users.noreply.github.com>
Alright I'm done with the changes. Because of the name, how about just |
Summary
This PR adds following:
VOICE_CHANNEL_EFFECT_SEND
eventcreate_
,edit_
,delete_
soundboard_sounds
property andget_
method (Guild
andClient
)GUILD_SOUNDBOARD_CREATE
,GUILD_SOUNDBOARD_UPDATE
,GUILD_SOUNDBOARD_DELETE
eventsCurrent Problems
Current "problems" on Discord's side, which is stated in the related soundboard PR
* As I tested myself, you can also get the soundboard sounds in the
GUILD_CREATE
event (e.g. on startup).** Not handled or documented as for now
***
sound_id
is always used,id
is not implementedOthers
Things which aren't documented in the related Discord PR:
override_path
is not included in any payload anymore -> both default and guild sounds uses an ID now, so e.g. the "bad umm tss" sound's ID is7
and so the cdn url ishttps://cdn.discordapp.com/soundboard-sounds/7
Related PRs: discord/discord-api-docs#6025 (voice channel effects), discord/discord-api-docs#6260 (soundboard)
Checklist
Testing pending