-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zone.js): allow enabling default beforeunload
handling
#55875
Closed
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, when zone.js was included, it wasn't possible to handle `beforeunload` events correctly if event handlers returned strings to prompt the user. With this change, we introduce a global configuration flag, `__zone_symbol__enable_beforeunload`, to allow consumers to enable the default `beforeunload` handling behavior. This flag is necessary to prevent any breaking changes resulting from this modification. The previous attempt to fix it caused a large number of failures in G3. Hence, we're hiding that fix behind the configuration flag. Closes angular#47579
JiaLiPassion
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
AndrewKushnir
added
target: patch
This PR is targeted for the next patch release
requires: TGP
This PR requires a passing TGP before merging is allowed
action: global presubmit
The PR is in need of a google3 global presubmit
labels
Jun 6, 2024
pullapprove
bot
removed
action: global presubmit
The PR is in need of a google3 global presubmit
requires: TGP
This PR requires a passing TGP before merging is allowed
labels
Jun 6, 2024
pullapprove
bot
added
the
action: global presubmit
The PR is in need of a google3 global presubmit
label
Jun 6, 2024
AndrewKushnir
added
action: merge
The PR is ready for merge by the caretaker
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
and removed
action: global presubmit
The PR is in need of a google3 global presubmit
labels
Jun 12, 2024
Caretaker note: TGP is "green", this PR is ready for merge. |
alxhub
pushed a commit
that referenced
this pull request
Jun 12, 2024
Prior to this commit, when zone.js was included, it wasn't possible to handle `beforeunload` events correctly if event handlers returned strings to prompt the user. With this change, we introduce a global configuration flag, `__zone_symbol__enable_beforeunload`, to allow consumers to enable the default `beforeunload` handling behavior. This flag is necessary to prevent any breaking changes resulting from this modification. The previous attempt to fix it caused a large number of failures in G3. Hence, we're hiding that fix behind the configuration flag. Closes #47579 PR Close #55875
This PR was merged into the repository by commit b8d5882. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
area: zones
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, when zone.js was included, it wasn't possible to handle
beforeunload
events correctly if event handlers returned strings to prompt the user.With this change, we introduce a global configuration flag,
__zone_symbol__enable_beforeunload
, to allow consumers to enable the defaultbeforeunload
handling behavior.This flag is necessary to prevent any breaking changes resulting from this modification. The previous attempt to fix it caused a large number of failures in G3. Hence, we're hiding that fix behind the configuration flag.
Closes #47579
Closes #52256