-
-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form): form state style exception in noStyle mode #48604
base: master
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48604 Failed ❌
Check Full Report for details |
What's the current wrong behavior? Is there some issue ref or provide a snapshot for this? |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@zombieJ |
@qhanw 能提供一个重现么? |
@afc163 @zombieJ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48604 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 12946 12948 +2
Branches 3382 3382
=========================================
+ Hits 12946 12948 +2 ☔ View full report in Codecov by Sentry. |
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
When form validation is performed with the
noStyle
property configured, there is a style exception in the successful state, and the style is also missing when thevariant
property is configured as 'filled' or 'borderless'.https://stackblitz.com/edit/react-c7ja7w?file=demo.tsx
variant: outlined
variant: filled
variant: borderless
📝 Changelog
Fix form validation style error when both 'noStyle' and 'variant' properties are configured as 'filled' or 'borderless'.
noStyle
时成功状态图标样式错误修复表单验证在同时配置
noStyle
与variant
属性为'filled'或'borderless'时样式错误☑️ Self-Check before Merge