Allow LuceneSourceOperator to early terminate #108820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @iverase, I've created a changelog YAML for you. |
iverase
added
:Analytics/EQL
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
| // Note: if (maxPageSize - currentPagePos) is a small "remaining" interval, this could lead to slow collection with a | ||
| // highly selective filter. Having a large "enough" difference between max- and minPageSize (and thus currentPagePos) | ||
| // alleviates this issue. | ||
| maxPageSize - currentPagePos |
There was a problem hiding this comment.
I don't know the scorer logic in detail, but I'm curious to understand what would be the implications of limiting the numDocs here instead, eg. using Math.min(maxPageSize - currentPagePos, remainingDocs) here rather than throwing and catching an exception.
There was a problem hiding this comment.
For what I see in the code, this value does not take into account deleted docs
There was a problem hiding this comment.
It makes a lot of sense, thanks!
FWIW, it looks good to me, but please wait for Nhat or Nik for a check
dnhatn
approved these changes
May 20, 2024
jedrazb
pushed a commit
to jedrazb/elasticsearch
that referenced
this pull request
May 21, 2024
We can make the LuceneSourceOperator collector to throw a CollectionTerminatedException whenever it has collected enough documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the geo benchmarks, this is clearly showing as an issue as we are iterating all the matched documents to get the first 10:
We can make the LuceneSourceOperator collector to throw a CollectionTerminatedException whenever it has collected enough documents.