ci: reduce list of releasable tags to feat, fix and perf
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
commented
May 17, 2024
.github/workflows/release-please.yml
Outdated
| { "type": "ci", "section": "Chores", "hidden": false }, | ||
| { "type": "refactor", "section": "Chores", "hidden": false }, | ||
| { "type": "test", "section": "Chores", "hidden": false } | ||
| { "type": "perf", "section": "Chores", "hidden": false } |
There was a problem hiding this comment.
Should we maybe rename this section to "Performance Improvements"?
By testing in a test repo, it seems that it won't close the existing release PR. But we could close it manually & remove the label & delete the branch, and next time we commit a |
nzakas
approved these changes
May 17, 2024
|
It didn't close the PR. Looks like it found there are no releasable commits and decided that there's no further action needed :) I'll remove the label, close the PR, and delete the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per eslint/eslint#18455, only commits tagged as
feat,fix, orperfshould trigger a release.This PR removes all other tags from
changelog-typesin the release-please configuration.This means that release-please will no longer consider commits tagged as
docs,build,chore,ci,refactor, ortestas "releasable units" and will thus no longer create a release PR for those commits. Note that this also means that those commits won't be included in the changelog.I'm not sure what will release-please do with #65 after we merge this. Since there are no "releasable units" committed at the moment, perhaps it will close the PR?