Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support node: protocol when building Playground #565

Merged
merged 2 commits into from May 15, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Updates webpack config to support node: protocol (e.g., require("node:path")).

This change is necessary in order to build the Playground from the upcoming ESLint v9.3.0 because it will use the node: protocol.

What changes did you make? (Give an overview)

Updated webpack config like in eslint/eslint#18434, as recommended in webpack/webpack#13290.

Related Issues

eslint/eslint#18434

Is there anything you'd like reviewers to focus on?

Check that the playground is working properly in the deploy preview.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label May 9, 2024
Copy link

netlify bot commented May 9, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 9aed04b
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/664472b4561d62000838d329
😎 Deploy Preview https://deploy-preview-565--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 9aed04b
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/664472b4aced270008d46ff7
😎 Deploy Preview https://deploy-preview-565--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 9aed04b
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/664472b44ddcec00087dcc09
😎 Deploy Preview https://deploy-preview-565--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 9aed04b
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/664472b4c9f5ad0008cc123a
😎 Deploy Preview https://deploy-preview-565--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 9aed04b
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/664472b4d47cde000843046d
😎 Deploy Preview https://deploy-preview-565--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 9aed04b
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/664472b4468a0f00089a4cdf
😎 Deploy Preview https://deploy-preview-565--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

"eslint": "latest"
"eslint": "github:eslint/eslint"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to test Playground with an ESLint version that uses the node: protocol. When it's verified that the Playground works well, I'll revert this change.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 9aed04b
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/664472b4454a6e00088d66fb
😎 Deploy Preview https://deploy-preview-565--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 9aed04b
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/664472b4753af10008d76592
😎 Deploy Preview https://deploy-preview-565--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas
Copy link
Member

nzakas commented May 13, 2024

@mdjermanovic this is marked as a draft. Is it ready for review?

@mdjermanovic
Copy link
Member Author

Yes, it's ready for review and for testing the Playground in the deploy preview.

I just marked it as a draft because the package.json change needs to be reverted before merging.

nzakas
nzakas previously approved these changes May 14, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested it out in the deploy preview and everything appears to work correctly.

@mdjermanovic mdjermanovic marked this pull request as ready for review May 15, 2024 08:34
@mdjermanovic mdjermanovic merged commit dbbf86d into main May 15, 2024
37 checks passed
@mdjermanovic mdjermanovic deleted the playground-nodeprotocol branch May 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants