Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Request: Consider also moving slightly-more-than-formatting rules out of core #17681

Closed
1 task done
JoshuaKGoldberg opened this issue Oct 25, 2023 · 17 comments · Fixed by #18435
Closed
1 task done

Change Request: Consider also moving slightly-more-than-formatting rules out of core #17681

JoshuaKGoldberg opened this issue Oct 25, 2023 · 17 comments · Fixed by #18435
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint

Comments

@JoshuaKGoldberg
Copy link
Contributor

ESLint version

8.52.0

What problem do you want to solve?

(Moving #17522 (comment) here) Following up on rules such as curly and padding-line-between-statements (eslint-stylistic/eslint-stylistic#26 -> eslint-stylistic/eslint-stylistic#26 (comment)): there are some core rules that aren't quite covered by some or all formatters, but are still within the realm of what eslint-stylistic would cover. Could we also move those rules out of core, with the intent to move them to eslint-stylistic?

What do you think is the correct solution?

Rules such as curly that are at or just above the formatting level suffer from many of the maintainability drawbacks mentioned in #17522. The eslint-stylistic project is intentionally named stylistic rather than formatting so that it can encompass more than just formatting rules. See eslint-stylistic/eslint-stylistic#26.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

Sorry for raising this so late after the initial discussion!
@JoshuaKGoldberg JoshuaKGoldberg added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint labels Oct 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 25, 2023
Closed
1 task
@nzakas
Copy link
Member

nzakas commented Oct 27, 2023

We already decided to keep curly and deprecate padding-line-between-statements.

What other rules are you referring to?

@JoshuaKGoldberg
Copy link
Contributor Author

We already decided to keep curly

I'm proposing that be reconsidered. Going through the blog post and rules list, the list I'm proposing for this issue is:

  • curly
  • multiline-comment-style
  • line-comment-position

To be honest, I was busy over the last month and wasn't able to find time to think deeply and comment in #17522. I wish I had posted this issue as a comment >2 weeks ago.

@nzakas
Copy link
Member

nzakas commented Oct 30, 2023

The decision on curly has already been made, and we discussed why we want to keep it on #17522, so we're not revisiting that.

I don't have a strong opinion about the other two, so I'd be fine with deprecating them. Do Prettier and/or dprint handle those?

@MrHBS

This comment was marked as duplicate.

Sign in to view
@nzakas
Copy link
Member

nzakas commented Nov 3, 2023

@MrHBS @meerhimmel I already answered about curly and no-unexpected-multiline on the original issue. We are not revisiting those decisions.

@antfu antfu mentioned this issue Nov 17, 2023
Closed
@kkmuffme
Copy link

Another one that is purely stylistic is capitalized-comments which should be moved to @Stylistic

@github-actions GitHub Actions
Copy link

Oops! It looks like we lost track of this issue. What do we want to do here? This issue will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Dec 30, 2023
@Rec0iL99 Rec0iL99 removed the Stale label Jan 3, 2024
@nzakas
Copy link
Member

nzakas commented Jan 3, 2024

@antfu do you have a list of additional rules that you think would make more sense to be in eslint-stylistic than the core?

@antfu
Copy link
Contributor

antfu commented Jan 8, 2024

For ESLint Stylistic we don't have a strong opinion on what rules to include, we generally take what ESLint/ts-eslint deprecated, as long as they fit in the category of "Stylistic".

Personally, I agree with Josh at #17681 (comment)

@Samuel-Therrien-Beslogic
Copy link

Crosslinking typescript-eslint/typescript-eslint#8102 and eslint-stylistic/eslint-stylistic#238 as it is stuck in this weird limbo of "Stylistic, but still in core, so no one touches it"

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Oops! It looks like we lost track of this issue. What do we want to do here? This issue will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Mar 7, 2024
@Rec0iL99
Copy link
Member

Ping @eslint/eslint-team. What are the next steps here?

@Rec0iL99 Rec0iL99 removed the Stale label Mar 14, 2024
@nzakas
Copy link
Member

nzakas commented Mar 22, 2024

Where we're at here is deciding whether we want to deprecate these two rules:

  • multiline-comment-style
  • line-comment-position

I'm fine with that, as they are just enforcing preferences. @mdjermanovic @fasttime what do you think?

@fasttime
Copy link
Member

Where we're at here is deciding whether we want to deprecate these two rules:

* `multiline-comment-style`

* `line-comment-position`

I think it makes sense to move these rules to @stylistic to ensure that they are properly maintained. So I'm in favor of deprecating them at this point.

@nzakas nzakas added the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Apr 2, 2024
@nzakas
Copy link
Member

nzakas commented Apr 2, 2024

TSC Summary: This issue seeks to deprecate two additional rules, multiline-comment-style and line-comment-position, and allow @stylistic to take over maintenance in the plugin.

TSC Question: Shall we do so?

@sam3k
Copy link
Contributor

sam3k commented Apr 8, 2024

Per 2024-04-04 TSC meeting, we've decided to deprecate these two rules and coordinate with eslint-stylistic to incorporate and maintain them going forward.

@sam3k sam3k removed the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Apr 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Oops! It looks like we lost track of this issue. What do we want to do here? This issue will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label May 8, 2024
@antfu antfu mentioned this issue May 8, 2024
Closed
4 tasks
aladdin-add added a commit to aladdin-add/eslint that referenced this issue May 9, 2024
@aladdin-add
feat: deprecate multiline-comment-style & line-comment-position
9b77e48 
fixes eslint#17681
aladdin-add added a commit to aladdin-add/eslint that referenced this issue May 9, 2024
@aladdin-add
feat: deprecate multiline-comment-style & line-comment-position
555a9a0 
fixes eslint#17681
@aladdin-add aladdin-add mentioned this issue May 9, 2024
Merged
@aladdin-add aladdin-add removed the Stale label May 9, 2024
aladdin-add added a commit to aladdin-add/eslint that referenced this issue May 9, 2024
@aladdin-add
feat: deprecate multiline-comment-style & line-comment-position
96e3cbd 
fixes eslint#17681
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 9, 2024
nzakas pushed a commit that referenced this issue May 9, 2024
@aladdin-add
feat: deprecate multiline-comment-style & line-comment-position (#…
05ef92d 
…18435)

* feat: deprecate multiline-comment-style & line-comment-position

fixes #17681

* fix: add @deprecated tag

* fix: deprecated tags

* docs: add rule links to the stylistic plugin
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: deprecate multiline-comment-style & line-comment-position aladdin-add/eslint