Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship][deliver][pilot] add support for app clips default experience metadata and review information #22041

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

sa-ma
Copy link

@sa-ma sa-ma commented May 20, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

This PR improves #21180 which seems to have been abandoned. My team and I have been using the changes from #21180 for a while now. I have synced the branches and fixed failing tests.

Resolves #17639

Description

Deliver
The following app clip default experience functionality has been added to deliver:

  • option to specify an action (PLAY, VIEW, ...)
  • option to specify localized subtitles
  • option to specify localized default experience header image
  • option to specify app clip review information

See #21180 for examples

Testing Steps

Basic Testing Setup

  1. Update Gemfile to 👇 and run bundle install, bundle update fastlane, or bundle update
gem "fastlane", git: 'https://github.com/sa-ma/fastlane.git', :branch => "pilot-app-clips"
  1. Upload a binary to ASC with an app clip target

What to Test

Deliver
Before specifying any deliver options:

  • Confirm that fastlane uses the live version's app clip metadata for the current edit version
    • It should copy over the action, subtitle, and header image of the live version

After specifying the app clip default experience deliver options:

  • Confirm the app clip default experience metadata specified in the deliver options reflects the ASC UI after running deliver
  • Confirm that fastlane enforces that the app clip header image is exactly 1800x1200 in size
  • Confirm that fastlane enforces only one app clip header image per locale
  • Confirm that the additional fastlane messages via UI.{message,important,...} are appropriate

Pilot

  • Confirm that the invocations appear on TestFlight

blesson3 and others added 23 commits September 8, 2023 10:09
@sa-ma sa-ma changed the title [spaceship][deliver][pilot] add support for app clips default experience metadata and review information [WIP] [spaceship][deliver][pilot] add support for app clips default experience metadata and review information May 20, 2024
@sa-ma sa-ma marked this pull request as draft May 20, 2024 13:06
@sa-ma sa-ma marked this pull request as ready for review May 27, 2024 04:09
@sa-ma sa-ma changed the title [WIP] [spaceship][deliver][pilot] add support for app clips default experience metadata and review information [spaceship][deliver][pilot] add support for app clips default experience metadata and review information May 27, 2024
@sa-ma
Copy link
Author

sa-ma commented May 27, 2024

@rogerluan and @AliSoftware please can you help review. There is no option to request for a reviewer on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deliver error for App containing an App Clip
3 participants