-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automatic publishing to crates.io on publish #8263
Conversation
Change secret name.
remove extra space added in merge
Thanks, meaning to get this in at some point. |
I manually ran a Release and get the following error. Mind if you can take a look? https://github.com/google/flatbuffers/actions/runs/9278729149/job/25530167137 |
@dbaileychess Oh! I must have missed a spot where I specified the relative directory of the crate. |
run: | ||
working-directory: ./rust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enough to get it working though 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbaileychess: I think this needs to be ./rust/flatbuffers
and maybe there needs to be a separate one for ./rust/flexbuffers
The last few releases of the rust crate have not gotten published to crates.io, presumably as they still require publishing manually. This causes a mismatch in CLI and library versions that can introduce breaking changes which are only solvable by pulling in flatbuffer versions directly from github instead of going through crates.io, which is not ideal (see #8257).
This PR adds support for automatically publishing to the rust crates library using
katyo/publish-crates
github action. This will need adding the appropriate secrets from your side.Resolves #8257