-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for rule based declarative conventions #29191
Conversation
Does not properly apply dependency conventions yet.
f5585e5
to
e86456e
Compare
...sl-provider/src/main/kotlin/org/gradle/internal/declarativedsl/settings/SettingsDslSchema.kt
Outdated
Show resolved
Hide resolved
...sl-provider/src/main/kotlin/org/gradle/internal/declarativedsl/settings/SettingsDslSchema.kt
Outdated
Show resolved
Hide resolved
...vider/src/main/kotlin/org/gradle/internal/declarativedsl/software/schemaFromSoftwareTypes.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/org/gradle/internal/declarativedsl/conventions/ConventionsResolutionProcessor.kt
Outdated
Show resolved
Hide resolved
...vider/src/main/kotlin/org/gradle/internal/declarativedsl/software/schemaFromSoftwareTypes.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/gradle/internal/declarativedsl/project/ProjectInterpretationSequenceStep.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/gradle/internal/declarativedsl/project/ProjectInterpretationSequenceStep.kt
Outdated
Show resolved
Hide resolved
Any code that does not create schema type instances should be compatible with TAPI proxies implementing the schema interfaces, so it should not depend on the implementation types.
It does not need to check each nested statement if it has `isTopLevelElement().implies(...)`.
@bot-gradle test this |
I've triggered the following builds for you. Click here to see all build failures. |
@bot-gradle test this |
I've triggered the following builds for you. Click here to see all build failures. |
...sl-provider/src/main/kotlin/org/gradle/internal/declarativedsl/settings/SettingsDslSchema.kt
Outdated
Show resolved
Hide resolved
The merge queue build has failed. Click here to see all failures. |
WARN: Based on labels, this pull request addresses notable issue but no changes to release note found. |
The merge queue build has failed. Click here to see all failures. |
WARN: Based on labels, this pull request addresses notable issue but no changes to release note found. |
Adds support for rule-based reusable conventions in build-level declarative dsl scripts.
Reviewing cheatsheet
Before merging the PR, comments starting with