Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using external libraries in version limited tooling-api code #29220

Merged
merged 2 commits into from
May 21, 2024

Conversation

jbartok
Copy link
Member

@jbartok jbartok commented May 20, 2024

Fixes

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@jbartok jbartok self-assigned this May 20, 2024
@jbartok jbartok added this to the 8.9 RC1 milestone May 20, 2024
@jbartok
Copy link
Member Author

jbartok commented May 20, 2024

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@jbartok jbartok marked this pull request as ready for review May 20, 2024 12:29
@jbartok jbartok requested a review from a team as a code owner May 20, 2024 12:29
@jbartok jbartok added this pull request to the merge queue May 21, 2024
@jbartok jbartok removed this pull request from the merge queue due to a manual request May 21, 2024
@jbartok jbartok added this pull request to the merge queue May 21, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has failed. Click here to see all failures.

@jbartok jbartok removed this pull request from the merge queue due to a manual request May 21, 2024
@jbartok jbartok added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit 553614f May 21, 2024
26 checks passed
@jbartok jbartok deleted the jb/tooling-api/internalize-utility-code branch May 21, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants