Add dreo integration fan #117789
Add dreo integration fan #117789
Conversation
There was a problem hiding this comment.
The repository seems to be empty:
https://github.com/dreo-team/hscloud
Could you take a look?
../Frenck
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Modify PR document link |
|
repository: https://github.com/dreo-team/hscloud, has been pushed |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Hey home-assistant! |
For more information about our Pull Request process, please see: https://developers.home-assistant.io/docs/review-process Thanks ../Frenck |
This comment has been minimized.
This comment has been minimized.
|
@dreo-team please dit not ask for review, for more information about the review process check the page I linked above. Thanks! |
There was a problem hiding this comment.
Some initial comment to get the review processes going. I've left some quick picks and some larger comments.
Additionally:
- The translation string (
strings.json) is missing. - We require integrations to provide tests for config flows, with a 100% test coverage. Please add tests.
.coveragerc
Outdated
| @@ -1733,6 +1733,7 @@ omit = | |||
| homeassistant/components/zwave_me/sensor.py | |||
| homeassistant/components/zwave_me/siren.py | |||
| homeassistant/components/zwave_me/switch.py | |||
| homeassistant/components/dreo/fan.py | |||
There was a problem hiding this comment.
Please keep this file alphabetically sorted
| from hscloud.hscloud import HsCloud | ||
|
|
||
| _LOGGER = logging.getLogger(__name__) | ||
| _LOGGER.setLevel(logging.INFO) |
There was a problem hiding this comment.
This shouldn't be controlled by the integration.
| _LOGGER.setLevel(logging.INFO) |
| login = await hass.async_add_executor_job(manager.login) | ||
| if not login: |
There was a problem hiding this comment.
login seems to be unused otherwise.
| login = await hass.async_add_executor_job(manager.login) | |
| if not login: | |
| if not await hass.async_add_executor_job(manager.login): |
| manager = HsCloud(username, password) | ||
| login = await hass.async_add_executor_job(manager.login) | ||
| if not login: | ||
| _LOGGER.error("Unable to login to the Dreo server") |
There was a problem hiding this comment.
- Should this raise an exception instead?
- This should ideally differentiate between an network/connection error and an authentication error (username/password doesn't match). Different exceptions can be raised for those cases.
| platforms = [] | ||
| fan_devices = [] | ||
| devices = await hass.async_add_executor_job(manager.get_devices) | ||
| for device in devices: | ||
| _platforms = PLATFORMS_CONFIG.get(device.get("model")) | ||
| for platform in _platforms: | ||
| if platform == FAN: | ||
| fan_devices.append(device) | ||
|
|
||
| platforms.extend(_platforms) | ||
|
|
||
| platforms = list(set(platforms)) |
There was a problem hiding this comment.
Shouldn't we just set up all platforms instead? And let the platform decide if it should add entities for a given device?
| _LOGGER.error(mask_error) | ||
| raise ValueError( | ||
| f"{exc}" | ||
| ) |
There was a problem hiding this comment.
These should raise an HomeAssistantError instead.
homeassistant/components/dreo/fan.py
Outdated
| from typing import Any | ||
|
|
||
| _LOGGER = logging.getLogger(__name__) | ||
| _LOGGER.setLevel(logging.INFO) |
There was a problem hiding this comment.
| _LOGGER.setLevel(logging.INFO) |
| "ssdp": [], | ||
| "zeroconf": [], | ||
| "homekit": {}, | ||
| "dependencies": [], |
There was a problem hiding this comment.
| "ssdp": [], | |
| "zeroconf": [], | |
| "homekit": {}, | |
| "dependencies": [], |
| { | ||
| "domain": "dreo", | ||
| "name": "Dreo", | ||
| "version": "1.0.0", |
There was a problem hiding this comment.
Versions are not used by built-in integrations.
| "version": "1.0.0", |
| "homekit": {}, | ||
| "dependencies": [], | ||
| "codeowners": [ | ||
| "@kane" |
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @dreo-team,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
355a20fa5b7b9e9b3442e8d698c5d577e9dbb589- No email found attached to the commit.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
There was a problem hiding this comment.
Hello @dreo-team,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
-
355a20fa5b7b9e9b3442e8d698c5d577e9dbb589- No email found attached to the commit. -
8a1af17441006bc12396e9357fe0f9efcf0e9d3c- No email found attached to the commit.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
There was a problem hiding this comment.
Hello @dreo-team,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
-
355a20fa5b7b9e9b3442e8d698c5d577e9dbb589- No email found attached to the commit. -
8a1af17441006bc12396e9357fe0f9efcf0e9d3c- No email found attached to the commit. -
6dcc109a15943a8dfd1f2a947faa1de74929fd25- No email found attached to the commit.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
There was a problem hiding this comment.
Hello @dreo-team,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
-
355a20fa5b7b9e9b3442e8d698c5d577e9dbb589- No email found attached to the commit. -
8a1af17441006bc12396e9357fe0f9efcf0e9d3c- No email found attached to the commit. -
6dcc109a15943a8dfd1f2a947faa1de74929fd25- No email found attached to the commit. -
2f57e33f5a6dfce01cef9ee90ecd78ae219af339- No email found attached to the commit.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
|
@dreo-team Why did you close this PR? ../Frenck |
Breaking change
Added dreo integration fan
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Link to documentation PR: home-assistant/home-assistant.io#32869
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: