fix(cli): Don't downgrade variables on migrate #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
andredestro,
markemer,
EiyuuZack,
theproducer and
nflsilva
jcesarmobile
changed the title
markemer
approved these changes
May 28, 2024
IT-MikeS
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the new barcode plugin I noticed that in the example app the
minSdkVersionwas downgraded from the required 26 to 22, so I checked if this was caused by migrate command, and it was, it changes any version in thevariables.gradleto match the default Capacitor ones, even if that means downgrading it.This PR checks the version and only update them if the value in
variables.gradleis smaller.