-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-sitter: Add the .slint UI language #3025
Conversation
We don't accept more grammars built-in to lapce |
22e4367
to
41557ce
Compare
The grammar is not open source so it can't be added |
@panekj Its licensed under GPLv3. |
@aurindam it is absolutely not, there is a directory with 3 different licences without any guidance what is supposed to be used (probably same how slint is licenced but I'm not going to be guessing)
|
@panekj Would a README in that folder clarifying that its triple licensed (like Slint) be sufficient? |
@aurindam yes, if it also includes a note on how the parser code is licenced, if |
@panekj: I just pushed a PR re-licensing the gammar.js to MIT (in the mono repo) and will put a copy of MIT into LICENSE.md in that tree-sitter-slint repo once that gets visible there. I hope that makes everything clearer. Thanks for raising this, licensing is always tricky to get right and feedback like this is really helpful. |
@panekj: I updated |
@hunger Thank you, it definitely works for me and assures the status of grammar "legality" :) |
Great! Anything else I can do to help from our side? |
Nope (unless you're interested in preparing queries for Lapce), I'm in progress of restructuring (and adding much more) grammars here: https://github.com/lapce/tree-sitter-grammars/tree/be-less-stupid Overall its just time consuming (and tedious) to prepare logic for updating and distributing grammars. |
@panekj will you be managing this from now, or shall I update and reopen the PR? |
If you remove the tree-sitter grammar (just add the Syntax definition and slint LSP id in proxy buffer) I'll merge it |
@panekj should be good to reopen and merge now I think |
@panekj: Sorry, I am not into GUI IDEs anymore. Been there, done that... |
CHANGELOG.md
if this change could be valuable to usersThis is paired with lapce/tree-sitter-grammars#28
I don't know if this is the correct method to go about this. There does not appear o be much documentation about adding languages.
Slint is a UI made with rust https://slint.dev/