-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Update volume meter appearance #10625
Conversation
I'm not a huge fan of the larger bars and handles, it feels a bit cheap and Fisher Pricey but maybe I need to get used it. The new UI seems a bit cramped with everything so close together. I feel like the icons for properties and mute should also be the same size if they are going next to each other. |
After hearing some responses from broadcast folks, I would suggest adding minor ticks back between -25dBFS and -5dBFS. |
I think you'd be hard pressed to find another audio application that has the meters as thin as we used to have them. The icons are intended to be the same size. There is an open PR to address that inconsistency
I'll try to play around with this |
dB font should have a higher contrast |
I'll have to defer to everyone else for discussion about all the details but I feel like colorblind people will definitely appreciate this PR. I also like how it adds the volume level lines to the slider. |
bb96113
to
820d5c8
Compare
Rebased this PR. Hopefully I got the changes correct. |
820d5c8
to
a746284
Compare
Overall I like some of the improvements, but man do the kebab and speaker buttons stick out like a sore thumb, particularly in the horizontal one. I'd prefer if the speaker remained without the button frame, not sure what your motivation was for adding that, but it looks "wrong" to me. We don't really do that with other symbolic buttons like the visibility or lock icons either, so it feels inconsistent with the sources dock. |
a746284
to
b9408e2
Compare
In the case of things like the Sources list or filters lists those symbolic buttons are inline elements. I want to make sure buttons have a clear visual appearance everywhere else. |
I agree that the mute icon should not look like a button (its behavior is more akin to a checkbox). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, I previously viewed these files and had no notes. LGTM
Noting the above feedback and not discounting it by merging, but going to see what the sentiment is during the beta cycle. If it's a common point of feedback I'll revert the styling changes as a fix. |
Description
Adjusts the layout and appearance of the audio mixer volume controls. Removes minor ticks, dims the decibel indication text, widens the meters for lower channel counts, and adds 10db ticks to the slider.
Before:
After:
Depends on #10602, or at least will prefer to merge that first so that this can be rebased against it.
Motivation and Context
Better use of space, less visual noise.
How Has This Been Tested?
Messed with audio sources and the audio sliders
Types of changes
Checklist: