-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Amazon IVS service #10634
Draft
palana
wants to merge
6
commits into
obsproject:master
Choose a base branch
from
palana:ruwen/add-amazon-ivs-service
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Amazon IVS service #10634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palana
force-pushed
the
ruwen/add-amazon-ivs-service
branch
from
May 3, 2024 15:20
cbc521c
to
3d5252c
Compare
Warchamp7
requested changes
May 4, 2024
WizardCM
added
Services
These are modifications to the Service list and are not tied to the release schedule
Enhancement
Improvement to existing functionality
labels
May 5, 2024
RytoEX
requested changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
palana
force-pushed
the
ruwen/add-amazon-ivs-service
branch
from
May 6, 2024 12:53
3d5252c
to
aa27260
Compare
6 tasks
This doesn't generally make the speedtest work for Amazon IVS, since most Amazon IVS channels will be disconnected if the bitrate being sent exceeds the upper limit for that channel.
RytoEX
force-pushed
the
ruwen/add-amazon-ivs-service
branch
from
May 21, 2024 22:09
aa27260
to
d7f5c3f
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
Improvement to existing functionality
Services
These are modifications to the Service list and are not tied to the release schedule
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #10543
Description
Add Amazon IVS service with behavior similar to Twitch, for customers of Amazon IVS and their users
Motivation and Context
Currently users of Amazon IVS customers have to use the custom service entry and enter both a URL and their stream key; with multitrack video they'd also have to enter a config URL (which is currently not exposed in the custom service UI)
With these changes users will generally only have to enter their stream key (and select "Auto (RTMPS, Recommended)" or "Auto (RTMP)" depending on whichever the Amazon IVS customer wants their users to use)
How Has This Been Tested?
Tested using various IVS channels created for testing purposes, some of which were allowlisted for multitrack video
Types of changes
Checklist: