-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-filters: Add white balance to color filter #10695
base: master
Are you sure you want to change the base?
Conversation
Is it common for white balance to be split into three separate sliders? Keeping in mind OBS is used by a variety of users, some with very intricate knowledge of video/colour and others who just want to make it look good with as little configuration as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use merge commits to catch up on branch/repo history. Use git rebase
.
This commit introduces a white balance adjustment option to the color correction filter. The following changes have been made: - Added new settings for red, green, and blue white balance adjustments. - Updated the color_correction_filter_data structure to include white balance variables. - Modified the create functions to initialize the white balance values. - Implemented white balance matrix computation in the update functions. - Integrated the white balance matrix into the final matrix used for color correction. - Updated the properties functions to add sliders for white balance adjustments. - Set default values for the new white balance settings. These changes allow users to fine-tune the white balance of their video sources, providing more control over the color correction process. Co-authored-by: Mariana Mendonca <mariana.mendonca@tecnico.ulisboa.pt>
This method offers the highest level of control, allowing precise fine-tuning of color balance across the spectrum. It's ideal for professional users who need to correct complex color casts or achieve specific color grading effects. |
I'm wondering if this makes sense as part of the color correction filter or if it should be a separate filter of it's own. |
White balance is usually under the color correction tab on photo and video editing programs such as Adobe Photoshop, After Effects, and others. Our decision was based on this and the fact that changing the white balance is color correcting the image. |
Just putting my vote that I agree on the above. I've actually several times added an OBS color correction filter mistakenly thinking it had white balance in the past, heh. I think it's a common enough paradigm that users would expect to find it there. |
Description
We added three white balance sliders to the color correction filter, as shown on the screenshots below:
The following changes have been made to the code:
Motivation and Context
Currently, OBS offers a variety of color correction filters, but lacks a dedicated white balance feature, which is essential for many users. This feature aims to address this problem by introducing three white balance sliders (red, green and blue) that adjust the color temperature.
Ideas website link: https://ideas.obsproject.com/posts/2582/white-balance
How Has This Been Tested?
We tested our feature in a macOS environment.
To test this feature you should go to the color correction filter and check the newly added sliders. If you change the value of the slider, the colours of your source will be updated.
Types of changes
Checklist: