Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 9.3.0 #51

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

baseballyama
Copy link
Contributor

eslint/eslint#18434 added the node: prefix to be used for imports from node. And it will breaks this plugin.

This is blocker of sveltejs/eslint-plugin-svelte#759

Copy link

changeset-bot bot commented May 19, 2024

🦋 Changeset detected

Latest commit: d67dcfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-eslint4b Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -4,7 +4,7 @@ import { name } from "eslint/package.json";
import * as TSESLintUtils from "@typescript-eslint/utils";
import * as TSESLintPlugin from "@typescript-eslint/eslint-plugin";

const linter = new Linter();
const linter = new Linter({ configType: "eslintrc" });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use legacy config if we install ESLint v9.

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@ota-meshi ota-meshi merged commit ee688ab into ota-meshi:main May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants