Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transfer document id in DTS #20342

Merged
merged 3 commits into from
May 22, 2024
Merged

Fix transfer document id in DTS #20342

merged 3 commits into from
May 22, 2024

Conversation

Bassel17
Copy link
Member

What does it do?

  • filtering out documentId key from data, so it's not removed when consolidating destination and source schemas

Why is it needed?

  • documentId property was not being transferred with the entities

How to test it?

  • attempt a transfer ( import, export, or a transfer between two projects)
  • documentId should not change, translations should be preserved and publishing status should be preserved as well

@Bassel17 Bassel17 added pr: fix This PR is fixing a bug fix:5 Fixed in Strapi 5 labels May 20, 2024
innerdvations
innerdvations reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works fine, but one minor annoying comment

It might be clearer logically if we add it to the other side, basically change attributes into attributesToKeep and make sure documentId is in there.

@vercel Vercel
Copy link

vercel bot commented May 21, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) May 21, 2024 9:29am

@Bassel17 Bassel17 merged commit d687b16 into v5/main May 22, 2024
77 of 83 checks passed
@Bassel17 Bassel17 deleted the fix/transfer-documentId branch May 22, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

@Convly Convly Convly approved these changes

Assignees
No one assigned
Labels
fix:5 Fixed in Strapi 5 pr: fix This PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bassel17 @innerdvations @Convly