Use AllocateDestinationBuffer instead of CreateUninitializedBuffer for #68242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_635356526
branch
2 times, most recently
from
fcf8a66
to
ebe6259
Compare
AsyncHostToDeviceTransferManager::Create. This is to synchronize the h2d stream with the compute stream. With this change, PjRtStreamExecutorBuffer::Delete doesn't need to schedule deallocation on compute stream if there are no other use cases that don't wait for the compute steam before writing to the HBM. PiperOrigin-RevId: 635508746
copybara-service
bot
force-pushed
the
exported_pr_635356526
branch
from
ebe6259
to
138d910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use AllocateDestinationBuffer instead of CreateUninitializedBuffer for
AsyncHostToDeviceTransferManager::Create. This is to synchronize the h2d stream with the compute stream.
With this change, PjRtStreamExecutorBuffer::Delete doesn't need to schedule deallocation on compute stream if there are no other use cases that don't wait for the compute steam before writing to the HBM.