-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update JWT auth documentation to use PyJWT instead of pyhon-jose #11589
Conversation
📝 Docs preview for commit 5a68592 at: https://604f2b88.fastapitiangolo.pages.dev |
📝 Docs preview for commit f252dc6 at: https://d2e11754.fastapitiangolo.pages.dev |
📝 Docs preview for commit 6734f79 at: https://ac0fd867.fastapitiangolo.pages.dev |
📝 Docs preview for commit 6734f79 at: https://0c8011f7.fastapitiangolo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is perfect except one small mistake with code line highlighting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @YuriiMotov mentioned, everything is amazing, especially with the non-maintenance of python-jose. Therefore, pyjwt is the best alternative.
LGTM 🚀
Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>
📝 Docs preview for commit 875c025 at: https://83636c12.fastapitiangolo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is good!
I paid special attention to highlighting the lines of code in all code blocks.
I also checked that all the necessary documentation pages have been corrected.
Thank you for your time and help |
Awesome, thank you @estebanx64! 🚀 🍰 And thanks for the reviews @yezz123 and @YuriiMotov, in particular for checking carefully the highlighting, there was a lot of that. 😅 😎 Thanks! |
Related: #9587 |
…iangolo#11589) Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
No description provided.