-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub udp support #4005
base: dev
Are you sure you want to change the base?
Stub udp support #4005
Conversation
I'm not sure why it says I want to merge into release, I did this, following instructions:
Did I mess up somehow? |
@rminnich I think it just needed the correct base branch in github UI. Just changed it to |
This is a bit odd:
|
The UDPConn struct is empty, and all operations return ErrNotImplemented. Once OpError.Timeout() is implemented, u-root wget and other tools will build. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
9b8e55f
to
8bf402f
Compare
it was something I missed, 2:30 am commits are not my forte it seems |
Always returns false, for now, until the infra for real timeouts is ready. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
data point: This is a pretty big step forward. |
@rminnich have you ever taken a look at the https://github.com/tinygo-org/tinygo/tree/net-submodule-netdev3 branch by any chance? It might do what you need already? It is a part of #3704 |
well I'm prob doing something wrong but and in building wget I'm back to
I don't see any of these functions in that submodule. There is some UDP support but not this? |
but if you do end up using the submodule, I suppose I can push a PR against that to get these 4 needed functions? |
Hi, I'm able to reproduce this issue. I'll work on porting the missing UDP parts to tinygo-net...
|
I opened an issue in tinygo-org/net to add UDP server support: tinygo-org/net#6 I'm trying to wrap my head around u-root. If we had UDP server working, would this mean you could flash a u-root image with wget to a tinygo target, and from there run wget on the network? I ask because it looks like this PR just stubs out the UDP server calls to get a compile. What does it mean for u-root to have full networking so netcat, wget, ping, dhclient work? |
I'm interested in picking this issue up again. Could we re-run the CI to check the current state of this PR? @rminnich @scottfeldman @deadprogram |
UDPConn is needed to get u-root commands such as wget to build. We still need OpError.Timeout():
I'd be much happier to just get rid of all tftp usage, but that is not easy, too many people still use it.
Rather than a new file, should this code just be in udpsock.go?