Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout documentation improvements #4196

Merged
merged 8 commits into from
May 22, 2024

Conversation

MDLC01
Copy link
Contributor

@MDLC01 MDLC01 commented May 20, 2024

I rephrased some parts and added a mention that layout provides context.

Sorry for the slight spam of documentation PRs from me.

crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
MDLC01 and others added 3 commits May 20, 2024 16:01
Co-authored-by: Eric Biedert <github@ericbiedert.de>
Co-authored-by: Eric Biedert <github@ericbiedert.de>
Co-authored-by: Eric Biedert <github@ericbiedert.de>
Copy link
Contributor

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Leaving some initial opinions.

crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
@PgBiel
Copy link
Contributor

PgBiel commented May 21, 2024

Sorry for the slight spam of documentation PRs from me.

Keep 'em coming! :)

MDLC01 and others added 2 commits May 21, 2024 12:29
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Copy link
Member

@laurmaedje laurmaedje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slight spam of documentation PRs from me.

Absolutely nothing to be sorry for, on the contrary! :)

crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
crates/typst/src/layout/layout.rs Outdated Show resolved Hide resolved
@laurmaedje laurmaedje added this pull request to the merge queue May 22, 2024
@laurmaedje
Copy link
Member

Thanks!

Merged via the queue into typst:main with commit babf641 May 22, 2024
6 checks passed
@MDLC01 MDLC01 deleted the layout-doc-improvements branch May 22, 2024 19:10
PgBiel added a commit to tulio240/typst that referenced this pull request May 30, 2024
Refactor frame metadata into tags (typst#4212)


Require `Send` and `Sync` for worlds (typst#4219)


Optimize counters and state (typst#4223)


Add `windows` method to array (typst#4136)

Improve `CITATION.cff` file (typst#4201)


Fix equation resizing when adding the equation number (typst#4179)


`layout` documentation improvements (typst#4196)

Allow somewhat arbitrary characters as `mat`, `vec` and `cases` `delim` (typst#4211)


Do layout short-circuit in flow instead of realization (typst#4231)


Split `BitSet` into two types and make it a bit nicer (typst#4249)


Set default value of `raw.theme` to `auto`, and allow setting `raw.theme` to `auto` (typst#4186)


Extended cargo installation instructions (typst#4168)

Hint for language-region pair on `text.lang` (typst#4183)


Improve macro docs (+ Native*Data docs) (typst#4240)


Rephrase the sentence on variable scope in Scripting documentation (typst#4250)


Refactor `Capable::vtable` to return `Option<NonNull<()>>` (typst#4252)


Nicer test helper CSS (typst#4269)


Trim weak spacing at line start/end in paragraph layout (typst#4087)


Add ability to choose between minified and pretty-printed JSON (typst#4161)


Refactor PDF export (typst#4154)

Reorder syntax kinds (typst#4287)


Fix figure centering (typst#4276)

Fix `Default` impls for AST nodes (typst#4288)


Bump libc to v0.2.155 (typst#4268)


Bump time dependency (typst#4294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants