IN-4121 - async hooks / api client #7155
Conversation
|
| } | ||
|
|
||
| next(); | ||
| getApiFunction(apiClientInstance, functionName, extensionName) |
There was a problem hiding this comment.
nit pick but I'd like to have async/await syntax in here as well (easier debugging imho), but you'd need to use this lib: https://www.npmjs.com/package/express-async-handler
There was a problem hiding this comment.
Can you make onCreate async in packages/middleware/__tests__/integration/bootstrap/server.ts to validate async behaviour?
# Conflicts: # packages/middleware/src/apiClientFactory/index.ts # packages/middleware/src/handlers/prepareApiFunction/getApiFunction.ts # packages/middleware/src/handlers/prepareApiFunction/index.ts
| ): (req, res, next) => Promise<any> { | ||
| return async (req, res, next) => { |
There was a problem hiding this comment.
I don't like this hack in here ;p I'd go with https://www.npmjs.com/package/express-async-handler and avoid defining the return type, then express will validate if it returns what's expected.
| ): (req, res, next) => Promise<any> { | |
| return async (req, res, next) => { | |
| ) { | |
| return asyncHandler(async (req, res, next) => { ... }); |
There was a problem hiding this comment.
You could also try without the lib and without the Promise in return type
| ); | ||
| .reduce(async (configSoFar, extension) => { | ||
| const resolvedConfig = await configSoFar; | ||
| return extension.beforeCreate({ configuration: resolvedConfig }); |
There was a problem hiding this comment.
await on lifecycles seems fine but I think you missed async behaviour on hooks like beforeCreate, afterCreate, beforeCall and afterCall
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist